Skip to content

Fall and wave detection ROS nodes #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 44 commits into from
Apr 20, 2023
Merged

Fall and wave detection ROS nodes #423

merged 44 commits into from
Apr 20, 2023

Conversation

tsampazk
Copy link
Collaborator

@tsampazk tsampazk commented Mar 29, 2023

Overhauled fall detection ROS1/2 nodes to work both by subscribing to an image topic and running pose estimation internally (original mode) and by subscribing to a pose topic and only running fall detection (new mode). Performance stuff is not added in this PR, but will get merged together with #419, i expect some conflicts as the merge is not straightforward, but i will handle it when it comes up.

Added wave detection ROS1/2 nodes that work similar to the new fall detection nodes. The wave detection method used is similar to the one used in the Lightweight OpenPose wave detection demo. Performance is added in this PR as the node is new.

Additionally added a new method to_ros_box to ROS1/2 bridges to be able to convert single bboxes.

TODO:

  • ROS2 fall detection readme update
  • ROS1 wave detection readme update
  • ROS2 wave detection node
  • ROS2 wave detection readme update

@thomaspeyrucain

@tsampazk tsampazk added the test sources Run style checks label Mar 29, 2023
@tsampazk tsampazk self-assigned this Mar 29, 2023
@tsampazk tsampazk marked this pull request as ready for review April 4, 2023 11:16
Copy link
Collaborator

@stefaniapedrazzi stefaniapedrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Everything seems fine.
I just have a couple of very minor comments.

@tsampazk
Copy link
Collaborator Author

Thanks for the review @stefaniapedrazzi, i applied your suggestions and i will now resolve the conflicts that arose by merging the performance PR. I will also add the performance stuff to the fall detection nodes.

@tsampazk tsampazk added test sources Run style checks and removed test sources Run style checks labels Apr 12, 2023
Copy link
Collaborator

@stefaniapedrazzi stefaniapedrazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Collaborator

@passalis passalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tsampazk tsampazk merged commit 3eeeb94 into develop Apr 20, 2023
@tsampazk tsampazk deleted the fall-wave-ros-nodes branch April 20, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test sources Run style checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants