-
Notifications
You must be signed in to change notification settings - Fork 102
Fall and wave detection ROS nodes #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ges are published in both modes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Everything seems fine.
I just have a couple of very minor comments.
projects/opendr_ws/src/opendr_perception/scripts/fall_detection_node.py
Outdated
Show resolved
Hide resolved
projects/opendr_ws/src/opendr_perception/scripts/fall_detection_node.py
Outdated
Show resolved
Hide resolved
projects/opendr_ws_2/src/opendr_perception/opendr_perception/wave_detection_node.py
Show resolved
Hide resolved
Thanks for the review @stefaniapedrazzi, i applied your suggestions and i will now resolve the conflicts that arose by merging the performance PR. I will also add the performance stuff to the fall detection nodes. |
projects/opendr_ws/src/opendr_perception/scripts/fall_detection_node.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Overhauled fall detection ROS1/2 nodes to work both by subscribing to an image topic and running pose estimation internally (original mode) and by subscribing to a pose topic and only running fall detection (new mode). Performance stuff is not added in this PR, but will get merged together with #419, i expect some conflicts as the merge is not straightforward, but i will handle it when it comes up.
Added wave detection ROS1/2 nodes that work similar to the new fall detection nodes. The wave detection method used is similar to the one used in the Lightweight OpenPose wave detection demo. Performance is added in this PR as the node is new.
Additionally added a new method
to_ros_box
to ROS1/2 bridges to be able to convert single bboxes.TODO:
@thomaspeyrucain